-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more semantic convention attributes of Apache RocketMQ #2881
Merged
carlosalberto
merged 1 commit into
open-telemetry:main
from
aaron-ai:feature/add_rocketmq_message_group
Nov 8, 2022
Merged
Add more semantic convention attributes of Apache RocketMQ #2881
carlosalberto
merged 1 commit into
open-telemetry:main
from
aaron-ai:feature/add_rocketmq_message_group
Nov 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-ai
force-pushed
the
feature/add_rocketmq_message_group
branch
from
October 17, 2022 03:47
13f2d58
to
bbd5454
Compare
aaron-ai
changed the title
Add "messaging.rocketmq.messsage_group" convention
Add more semantics convention attributes of Apache RocketMQ
Oct 17, 2022
aaron-ai
changed the title
Add more semantics convention attributes of Apache RocketMQ
Add more semantic convention attributes of Apache RocketMQ
Oct 17, 2022
aaron-ai
force-pushed
the
feature/add_rocketmq_message_group
branch
7 times, most recently
from
October 23, 2022 03:04
6d4819a
to
23d4406
Compare
@arminru @jsuereth @tigrannajaryan @carlosalberto Could you help to review it? |
carlosalberto
approved these changes
Oct 24, 2022
It would be good to get a review from the messaging working group. |
aaron-ai
force-pushed
the
feature/add_rocketmq_message_group
branch
from
October 25, 2022 01:44
23d4406
to
3721973
Compare
It seems that markdown-link-check is failed, which is not related to this pull request. re-run is required. |
aaron-ai
force-pushed
the
feature/add_rocketmq_message_group
branch
from
October 26, 2022 04:51
3721973
to
8f7d9d3
Compare
6 tasks
aaron-ai
force-pushed
the
feature/add_rocketmq_message_group
branch
from
November 3, 2022 01:21
8f7d9d3
to
704c641
Compare
aaron-ai
force-pushed
the
feature/add_rocketmq_message_group
branch
from
November 4, 2022 07:01
704c641
to
bfac710
Compare
Maybe @pyohannes @joaopgrassi can review this one as well? (or anybody from the messaging wg ;) ) |
pyohannes
approved these changes
Nov 4, 2022
trask
approved these changes
Nov 5, 2022
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2880